Add tap tester #14

loeakaodas · 2021-09-30T02:35:30Z

Description of change

adding tap-tester tests as per TDL-14836
this PR also includes commits from Rewrite tap with class approach #13

Manual QA steps

ran tap manually
ran singer-check-tap
ran target-stitch --dry-run
ran tap-tester tests locally

Risks

Rollback steps

revert this branch

* actually raise 429 error * pylint fixes

* __init__.py * client.py * sync.py

* indentation fixes to match PEP8 * unpacking result of client.get with `records, _`

* bumping singer-python * adding dev requirements

kspeer825

Some requests for test changes.

.circleci/config.yml

tests/test_recharge_discovery.py

tests/test_recharge_pagination.py

tests/test_recharge_start_date.py

* Link header was not honoring original call params and duplicating records

tap_recharge/client.py

tap_recharge/streams.py

…o singer-io-pr-14

tests/test_recharge_start_date.py

tests/test_recharge_discovery.py

* adjust start_date_2 to work with data * add stream replication methods for tests * modify/add assertions based on stream replication methods and data

kspeer825

Tests approved

Andrey Kabanov added 21 commits September 17, 2021 16:22

changes to tap entrypoint to work with rest of tap

16fea46

changes to discover.py to work with rest of tap

f080302

changes to schema.py to work with rest of the tap

e6bfe76

changes to sync.py to work with rest of the tap

0857584

updated README links to documentation

bd8bac8

changes to client.py:

cb60599

* actually raise 429 error * pylint fixes

initial working version of streams.py

8c8a893

adding pagination to streams.py

7aa3c20

adding links object as part of client return for pagination changes

806997c

adjusting indentation to match PEP8:

3f8a7b5

* __init__.py * client.py * sync.py

removing extraneous keys and related functions from discover.py

694a4a5

changes to streams.py:

19418cd

* indentation fixes to match PEP8 * unpacking result of client.get with `records, _`

adding tap-tester base.py

e138b89

adding tap-tester sync canary

b8d6985

adding tap-tester discovery

da59cd0

adding tap-tester start date

bc3e350

adding tap-tester automated fields

4586cdd

changes to setup.py:

531cada

* bumping singer-python * adding dev requirements

adding circleci config

d537130

adding tap-tester pagination

c3cdcb0

fix for onetimes stream not supporting cursor based pagination

723ccda

kspeer825 suggested changes Sep 30, 2021

View reviewed changes

Andrey Kabanov added 4 commits September 30, 2021 17:36

updating cirlce config

c0c5227

adding additional assertions per PR feedback

d5f9756

add additional streams to pagination test

9e7f8e8

switch customers stream to page based

43c0e52

* Link header was not honoring original call params and duplicating records

loeakaodas requested a review from kspeer825 October 1, 2021 00:44

luandy64 added 2 commits October 1, 2021 13:32

Make pylint happy

39fdb3c

Update tap-tester invocation

267616a

luandy64 mentioned this pull request Oct 1, 2021

Rewrite tap with class approach #13

Closed

pylint fixes

ea83b51

luandy64 reviewed Oct 1, 2021

View reviewed changes

tap_recharge/client.py Outdated Show resolved Hide resolved

luandy64 reviewed Oct 1, 2021

View reviewed changes

tap_recharge/streams.py Outdated Show resolved Hide resolved

Andrey Kabanov added 4 commits October 1, 2021 12:10

Merge branch 'pr-14' of https://github.com/singer-io/tap-recharge int…

dcbba56

…o singer-io-pr-14

Merge branch 'singer-io-pr-14' into add-tap-tester

3e3db8b

remove extraneous string interpolation

715807e

remove extraneous class attributes for shop stream

132eee7

kspeer825 suggested changes Oct 4, 2021

View reviewed changes

tests/test_recharge_start_date.py Outdated Show resolved Hide resolved

tests/test_recharge_discovery.py Show resolved Hide resolved

Andrey Kabanov added 2 commits October 4, 2021 17:04

fixes to start_date test:

6f35642

* adjust start_date_2 to work with data * add stream replication methods for tests * modify/add assertions based on stream replication methods and data

adding assertion for valid-replication-keys to discover test

e70536d

loeakaodas requested a review from kspeer825 October 5, 2021 00:28

kspeer825 approved these changes Oct 5, 2021

View reviewed changes

luandy64 approved these changes Oct 11, 2021

View reviewed changes

luandy64 merged commit 839ebb3 into singer-io:master Oct 11, 2021

luandy64 mentioned this pull request Oct 11, 2021

Bump to v1.1.0, update changelog #15

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tap tester #14

Add tap tester #14

loeakaodas commented Sep 30, 2021

kspeer825 left a comment

kspeer825 left a comment

Add tap tester #14

Add tap tester #14

Conversation

loeakaodas commented Sep 30, 2021

Description of change

Manual QA steps

Risks

Rollback steps

kspeer825 left a comment

Choose a reason for hiding this comment

kspeer825 left a comment

Choose a reason for hiding this comment